Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODLOGINKC-35: fix error code while 401 in Keycloak #100

Merged

Conversation

yauhen-vavilkin
Copy link
Contributor

@yauhen-vavilkin yauhen-vavilkin commented Oct 24, 2024

Purpose

https://folio-org.atlassian.net/browse/MODLOGINKC-35
Our assumption that mod-login-keycloak return 400 to kong, but actual response code is 401. As well there is no logs in login-keycloak at all, which makes hard to troubleshoot the problem. Please update logging for those services with correct status code

Approach

  • catch 401 Keycloak error
  • add tests /update tests

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added, or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

@yauhen-vavilkin yauhen-vavilkin requested a review from a team as a code owner October 24, 2024 10:51
Copy link

@yauhen-vavilkin yauhen-vavilkin merged commit 456e10f into master Oct 24, 2024
8 checks passed
@yauhen-vavilkin yauhen-vavilkin deleted the bug/MODLOGINKC-35-fix-error-code-while-401-in-keycloak branch October 24, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants