Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCONSKC-12: Port Poppy CSP changes from mod-consortia -> mod-consortia-keycloak #52

Merged
merged 3 commits into from
May 7, 2024

Conversation

OleksiiKuzminov
Copy link
Collaborator

@OleksiiKuzminov OleksiiKuzminov commented May 7, 2024

Purpose

There have been 3 Poppy CSPs, some of which included changes/fixes in mod-consortia. We need to port these changes to mod-consortia-keycloak.

Approach

TODOS and Open Questions

  • Check logging

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added, or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do Rally stories exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all the appropriate links to blocked/related issues?
  • Are the Rally stories under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally, all the PRs involved in breaking changes would be merged on the same day to avoid breaking the folio-testing
environment. Communication is paramount if that is to be achieved, especially as the number of inter-module and
inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the
responsibility of the PR assignee.

@OleksiiKuzminov OleksiiKuzminov self-assigned this May 7, 2024
@OleksiiKuzminov OleksiiKuzminov requested a review from a team as a code owner May 7, 2024 08:13
Copy link

sonarqubecloud bot commented May 7, 2024

@OleksiiKuzminov OleksiiKuzminov merged commit 413728c into master May 7, 2024
6 checks passed
@OleksiiKuzminov OleksiiKuzminov deleted the MODCONSKC-12 branch May 7, 2024 10:02
dmytrokrutii pushed a commit to dmytrokrutii/mod-consortia-keycloak that referenced this pull request Sep 25, 2024
FOLIO-3678 MODCON-54 Use GitHub Workflows api-lint and api-schema-lint and api-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants