Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODCONSKC-56] Remove self endpoints invocations #135

Merged
merged 14 commits into from
Jan 20, 2025
Merged

Conversation

Saba-Zedginidze-EPAM
Copy link
Contributor

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM commented Jan 8, 2025

Purpose

[MODCONSKC-56] Remove self endpoints invocations

Approach

  • Remove clients for self endpoint invocations
  • Add TenantManager alongside TenantService and divide functionality between the two. This was beneficial to avoid complex circular dependencies and improve testing
  • Refactor SyncPrimaryAffiliationService to use its own methods instead of self invocation. Includes reference to self in order to utilize @transactional annotation and not bypass the proxy
  • Support retry logic for adding tenant by checking if consortium configuration or user tenant exist to prevent creating it
  • Update unit tests

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM requested a review from a team as a code owner January 8, 2025 18:44
zburke
zburke previously requested changes Jan 8, 2025
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't enough info in this PR to review your changes.

  • You must summarize the changes in the title
  • You must provide context for the changes in the description -- not just the "what", which we can get from git diff, but the "why". If you're fixing a bug, describe the bug and describe why this fix is the correct fix; do not force me to re-triage the problem. If you don't want to use the existing template, fine, but remove it and provide your own explanation.
  • You must update NEWS.md
  • You should correctly label the Jira ticket, MODCONSKC-56, not Modconskc 56
  • It's polite to put a link back to Jira in the description to make it easy for reviewers to check if the work that was done matches the work that was requested

These are general guidelines you should follow on every PR.

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM marked this pull request as draft January 8, 2025 19:54
@Saba-Zedginidze-EPAM
Copy link
Contributor Author

This is a draft PR so far, will include necessary details soon

# Conflicts:
#	src/test/java/org/folio/consortia/service/impl/SyncPrimaryAffiliationServiceImplTest.java
@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM changed the title Modconskc 56 [MODCONSKC-56] Remove self endpoints invocations Jan 8, 2025
@zburke zburke dismissed their stale review January 8, 2025 22:10

PR updated as requested; thank you!

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM marked this pull request as ready for review January 9, 2025 15:47
@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM requested review from a team January 9, 2025 15:48
@SerhiiNosko SerhiiNosko merged commit f1f280f into master Jan 20, 2025
6 checks passed
@SerhiiNosko SerhiiNosko deleted the MODCONSKC-56 branch January 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants