-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODCONSKC-56] Remove self endpoints invocations #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't enough info in this PR to review your changes.
- You must summarize the changes in the title
- You must provide context for the changes in the description -- not just the "what", which we can get from
git diff
, but the "why". If you're fixing a bug, describe the bug and describe why this fix is the correct fix; do not force me to re-triage the problem. If you don't want to use the existing template, fine, but remove it and provide your own explanation. - You must update NEWS.md
- You should correctly label the Jira ticket,
MODCONSKC-56
, notModconskc 56
- It's polite to put a link back to Jira in the description to make it easy for reviewers to check if the work that was done matches the work that was requested
These are general guidelines you should follow on every PR.
This is a draft PR so far, will include necessary details soon |
# Conflicts: # src/test/java/org/folio/consortia/service/impl/SyncPrimaryAffiliationServiceImplTest.java
31d2092
to
df0fef2
Compare
…eycloak into MODCONSKC-56 # Conflicts: # src/test/java/org/folio/consortia/controller/TenantControllerTest.java
Quality Gate passedIssues Measures |
Purpose
[MODCONSKC-56] Remove self endpoints invocations
Approach