Force test:// URI to be used in mocked connections #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to 801ce47 any URL could be used when mocking and it had preconfigured responses, but this regressed and could cause real system connections to go through. This forces the URL to use the test:// scheme which still allows the use of test:///path/to/host/definitions as documented. Fixes: 801ce47 ("Use test:///default in tests") Reference: https://libvirt.org/uri.html#test-test-uris
stejskalleos
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Tested together with theforeman/foreman#10377 & it fixed the issue.
evgeni
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 801ce47 any URL could be used when mocking and it had preconfigured responses, but this regressed and could cause real system connections to go through.
This forces the URL to use the test:// scheme which still allows the use of test:///path/to/host/definitions as documented.
Fixes: 801ce47 ("Use test:///default in tests")
Reference: https://libvirt.org/uri.html#test-test-uris