Drop warning if region is not us-east-1 in mock #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if `Fog.mock!` were used with some other region and the bucket already existed, a warning message, `Your region <region> does not match the default region 'us-east-1'". We were seeing a lot of these warnings in our test suite. As far as I can tell, there's no reason why some other region can't be used, so drop this.
stanhu
force-pushed
the
sh-drop-mock-region-warning
branch
from
3e2ccf5 to
e936356
Compare
|
@geemus I think this logic has been in place for a long time, but I'm not sure why. Is this just to ensure that tests only use one well-defined region? I suppose tests could fail if buckets with the same name but different regions are used. |
|
@stanhu good question. Presumably we had a reason at the time, but I certainly don't remember it now. I agree it seems pretty arbitrary and although it could lead to some issues with re-used bucket names it's not clear that is any worse than the current confusing and probably not very true-to-real mock behavior. |
geemus
approved these changes
Aug 9, 2024
|
Released in v3.25.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if
Fog.mock!were used with some other region and the bucket already existed, a warning message,Your region <region> does not match the default region 'us-east-1'.We were seeing a lot of these warnings in our test suite. As far as I can tell, there's no reason why some other region can't be used, so drop this.