Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vscode as IDE #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Using vscode as IDE #1

wants to merge 2 commits into from

Conversation

drebatto
Copy link

Hi, I started to work through the GUI code, in order to provide patches to make it pylint-compliant.

To quickly move from the endless list of pylint complaints to the relevant code lines, I ended up using an IDE. Microsoft's Visual Studio Code was the easiest to set up, and it has good integration with git and Python tools. I include the simple configuration file needed to enable proper code parsing.
I also added a configuration file for pylint (.pylintrc in the top-level directory), with all the default checkers enabled and the list of the external modules required for symbol recognition.
In order to use pylint from the command line (e.g. for travis CI), it is sufficient to specify the configuration file with the --rcfile=<filepath> option (unless it is in the current directory).

I started to experiment on mvm_gui.py (the GUI launcher) and I brought it to score 10/10. To achieve that, I had to exclude the redefined-variable-type checker, as it is bugged.

If you are fine with this kind of revision, I would start to do the same with all the code.

@garganti
Copy link

there is an issue on the main repo about this:
https://github.com/MechanicalVentilatorMilano/gui/issues/184

@drebatto
Copy link
Author

Thanks, I just received the notification. I guess I can withdraw my pull request, as most work has been done there already.
Can I still contribute to the project with test units and/or code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants