Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I started to work through the GUI code, in order to provide patches to make it pylint-compliant.
To quickly move from the endless list of pylint complaints to the relevant code lines, I ended up using an IDE. Microsoft's Visual Studio Code was the easiest to set up, and it has good integration with git and Python tools. I include the simple configuration file needed to enable proper code parsing.
I also added a configuration file for pylint (
.pylintrc
in the top-level directory), with all the default checkers enabled and the list of the external modules required for symbol recognition.In order to use
pylint
from the command line (e.g. for travis CI), it is sufficient to specify the configuration file with the--rcfile=<filepath>
option (unless it is in the current directory).I started to experiment on mvm_gui.py (the GUI launcher) and I brought it to score 10/10. To achieve that, I had to exclude the
redefined-variable-type
checker, as it is bugged.If you are fine with this kind of revision, I would start to do the same with all the code.