Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fixed_inputs param for array nodes #3106

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Feb 3, 2025

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 47.45%. Comparing base (4208a64) to head (2a43ff9).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/core/array_node.py 18.75% 13 Missing ⚠️
flytekit/tools/translator.py 0.00% 11 Missing ⚠️
flytekit/core/node.py 50.00% 2 Missing and 1 partial ⚠️
flytekit/models/core/workflow.py 50.00% 2 Missing ⚠️
flytekit/core/array_node_map_task.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   51.81%   47.45%   -4.37%     
==========================================
  Files         202      203       +1     
  Lines       21469    21648     +179     
  Branches     2766     2791      +25     
==========================================
- Hits        11125    10272     -853     
- Misses       9735    10856    +1121     
+ Partials      609      520      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants