Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected typo in simbrief-data support-request embed and also correction in contributing.md #71

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

JasonO99
Copy link
Contributor

Description

Small PR to correct two things

  • typo in the embed for simbrief-data support-request - this was telling users to input simbrief_data retrieve rather than what the actual command is, simbrief-data retrieve.
  • In contributing.md the Ground Rules give an example of naming things correctly. It still makes reference to ensuring simBrief is used instead of SimBrief, however SimBrief is now correct. Have swapped these around.

Change log entries added.

Test Results

I have not tested this as I do not have a Bot test environment setup, however the only change impacting the bot directly is a single character and the second commit is for a GitHub page.

Discord Username

jason_91

JasonO99 added 3 commits July 16, 2024 10:40
Swapped the underscore for a dash, inline with the actual command.
SimBrief appear to be have changed the way their service is displayed, with it previously being simBrief, it is now SimBrief as confirmed via their website. As such I have switched them around in the Ground Rules.
Copy link
Contributor

@ExampleWasTaken ExampleWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@benw202 benw202 merged commit efc02ee into flybywiresim:staging Jul 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants