fix: vatsim events max fields #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limits the amount of fetched Vatsim events to 5 instead of 6. We can now only ever populate 25 fields in this command, rectifying the error
Also adds an error embed to the command handlers to make it more clear on what went wrong (this isn't specific to the vatsim events command) as an example using this command:
The application is left thinking, as the error is outside of the command, but in the handler itself. Other commands will continue to run and the
/vatsim eventscommand would time out after 15 minutes as per Discord guidelines.Test Results
Discord Username
benw8484