feat(a32nx/fms): database holds

[tracernz]

Fixes #[issue_no]

Summary of Changes

Adds support for database holds using the terminal area holding pattern data added in MSFS2024.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Try to insert a hold on a terminal are waypoint that has a hold defined in the LIDO charts (https://planner.flightsimulator.com). Make sure the hold parameters match the chart. You should get a database hold. Edit a parameter such as the time/distance, and ensure you get a REVERT TO DATABASE prompt, and that it works.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

[BlueberryKing]

If you want, you could do

Suggested change

	return altitude >= hold.altitude1 ? 0 : hold.altitude1 - altitude;
	return Math.max(0, hold.altitude1 - altitude);

The same for the next case.

[utkrishtm]

Hey, do you have any examples of airports that may have such database holds? I tried KJFK, EGLL, and KLGA, which all have holds on their arrival charts. However, the holds came into the CDU as "Computed" rather than "Database." I also disabled the navigraph cycle to force it to use the Asobo-provided one.

[Benjozork]

Hey, do you have any examples of airports that may have such database holds? I tried KJFK, EGLL, and KLGA, which all have holds on their arrival charts. However, the holds came into the CDU as "Computed" rather than "Database." I also disabled the navigraph cycle to force it to use the Asobo-provided one.

Are you testing in MSFS2024 and with this build?

[utkrishtm]

Hey, do you have any examples of airports that may have such database holds? I tried KJFK, EGLL, and KLGA, which all have holds on their arrival charts. However, the holds came into the CDU as "Computed" rather than "Database." I also disabled the navigraph cycle to force it to use the Asobo-provided one.

Are you testing in MSFS2024 and with this build?

Yes

[tracernz]

Thanks! Found an issue, where the terminal waypoint that the hold belongs to belongs to a different airport than the hold. The way MSFS allows access to the holds at the moment is quite awkward unfortunately, as we can only get them from the airport facility.

KJFK has holding patterns at:

ILGEZ
JOEYL
JSSIE
SMITS
ZAPOM
GUESS
JETAX
PIRCE
DEERY
DUFFY
HURBO

EGLL has holding patterns at:

R068I
R070O
R270J
R137M
R223M
R277M
VLN13
72SAM
72SAM
SAM08
BINGO
BINGO
DITTO

KLGA has holding patterns at:

ILGEZ
JOEYL
JSSIE
SMITS
ZAPOM
GUESS
JETAX
PIRCE
DEERY
DUFFY
HIRBO
GREKO
GREKO
YOMAN

These should all work now if:

• you're lucky and the terminal waypoint belongs to the same airport as the holding pattern, or
• your origin or destination airport has a holding pattern at this waypoint.

Only the first one was the case before, and that always worked in NZ where I tested.

[utkrishtm]

Got it, will continue my testing now. Thanks!

[utkrishtm]

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9775
Aircraft : A32NX
Tier of Testing : 1
Date : 23/01/2025

Testing Process:

• Tested KJFK 04L with hold at DUFFY. Was able to make changes and revert back to the database hold
• Tested KLGA 13 and 22 with hold at GREKO and PROUD respectively. Can revert to the database hold
• Tested RJAA 34L with hold at BINKS. Can revert to the database hold
• Able to edit specific parameters for the hold and revert back to the database hold parameters.

Testing Results:
Passed

Media: