Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2 #8331

Closed
wants to merge 731 commits into from
Closed

feat(a380x/mfd): MFD/FMS based on avionics framework and fms-v2 #8331

wants to merge 731 commits into from

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 16, 2023 •
edited
Loading

Summary of Changes

This PR adds the MFD including FMS functionality. Details to follow.

Depends on #7692

Notes on behavior:

  1. Enter A320 weights, not A380 weights. For example ZFW = 50t, BLOCK = 15t works
  2. Use TOGA for take-off. Don't use FLEX for T/O right now. For temperatures above a threshold, N1 doesn't go high enough to trigger a flight phase change into T/O, which doesn't start the waypoint sequencing.
  3. Predictions on FPLN page only visible if ZFW, BLOCK and V2 speed are set

Influence on other systems:

  • For correct behavior of PFD indications and callouts, FWC and GPWS are copied from A320 legacy JS code, converted to TS and put into SystemsHost. Will be removed once Rust implementation is up&running
  • dummy placeholder for VD (vertical display) introduced to fill blank spot in ND; to be removed once Sven's PR is finished&merged

Screenshots (if necessary)

References

A380 FCOM, youtube videos

Reference for new ECAMFontNumericalValues (strike through 0):
image

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

BlueberryKing and others added 24 commits December 7, 2023 21:04
@BlueberryKing
Refactor LOC tuning by ident
5d49950
@BlueberryKing
Merge remote-tracking branch 'upstream/master' into fms-v2
7e6129e
@BlueberryKing
Improve LDA/SDF approach handling
9b58b76
@flogross89
introduce data entry errors, set simvars (port from a32nx fmc code)
00f399d
@Saschl @BlueberryKing
feat: crz alt import and more (flybywiresim#8308)
406c9ad 
* fix: move crz fl, trans alt/lvl, ci and fl no to flightplan

* small refactor

* small improvement

* refactor: avoid direct flightplan manipulation in uplink

* fix typo

* refactor: use get/set

* fix: trans level and fl no parsing

* fix: lvar bogus

* fix: remove duplicate conidition, number type for lvar

* addressing review comments

* revert some more unrelated changes

* access flightplan object directly for read operations

* woops

* fix: undefined access

* fix: more undefined oopsies

* Fix small formatting issues

* Move away from subjects on flightplan

* Import callsign instead of flight number

---------

Co-authored-by: BBK <[email protected]>
@flogross89
calculate operating speeds, add POSITION/NAVAIDS, add managed speed
9947584
@flogross89
fix type errors and PFD
9d2eed5
@flogross89
change error handler architecture
fd83316
@flogross89
operating speeds update
31e5f6a
@flogross89
Merge remote-tracking branch 'origin/fms-v2' into feat-mfd-a380x-fmsv2
b37809a
@flogross89
update to subject-less performance data
383d5d7
@flogross89
re-integrate geometry guards
d12e606
@flogross89
fmgc fixes
8f40aab
@flogross89
integrate CdsDisplayUnit, adapt TO speed check, use efisInterface,
2723c36
@flogross89
InputField: fix delete value case, fix PERF speed tables
bf37aa7
@flogross89
add REC MAX FL and OPT FL on PERF page
055be99
@Benjozork
fix some typescript path stuff
663dac3
@Benjozork
fix simbrief type usage in efb
1e6203b
@Benjozork
generic flight plan perf data types
5aae038
@Benjozork
Merge remote-tracking branch 'origin/fms-v2' into feat-mfd-a380x-fmsv2
489f5c9 
# Conflicts:
#	fbw-a32nx/src/base/flybywire-aircraft-a320-neo/html_ui/Pages/VCockpit/Instruments/NavSystems/A320_Neo/A32NX_NavSystem.js
#	fbw-a32nx/src/systems/fmgc/src/flightplanning/new/FlightPlanService.ts
@Benjozork
specify typescript paths that don't include react code for MFD
783c253
@Benjozork
fixes after fms-v2 changes
d828791
@Benjozork
fix various typing issues and missing properties
f203c3f
@Benjozork
Merge remote-tracking branch 'origin/fms-v2' into feat-mfd-a380x-fmsv2
fcd1c72
BlueberryKing and others added 18 commits February 4, 2024 21:38
@flogross89 flogross89 marked this pull request as draft February 7, 2024 22:52
@flogross89 flogross89 added QA A380 Only QA only for A380 required Do Not Merge labels Feb 12, 2024
@flogross89 flogross89 closed this Feb 18, 2024
@flogross89 flogross89 deleted the feat-mfd-a380x-fmsv2 branch February 18, 2024 17:59
@flogross89 flogross89 mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge QA A380 Only QA only for A380 required
Projects
Quality Assurance
Status: ❌ Cancelled/Unfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flogross89 @johnpmaguire @BlueberryKing @Saschl @Benjozork @frankkopp