Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atsu): Departure request page not updating after successful station insert #8279

Merged

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Oct 31, 2023

Fixes #[issue_no]

Summary of Changes

ATSU departure request page now refreshes after a valid station has been inserted. Previously it wouldn't refresh unless a manual refresh occurred due to a manual input for example.

Screenshots (if necessary)

Before & After

2023-10-31.20-34-05.mp4
2023-10-31.21-17-15.mp4

References

Additional context

Ignore the silly branch name :)

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

Insert a valid hoppie station on the ATSU DEPART REQ page and make sure the page updates the station without any further user input (assuming no hoppie related occurs)

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@BravoMike99 BravoMike99 force-pushed the fix-atis-departreq-refresh branch from 6f1623d to 74eb05d Compare October 31, 2023 21:48
Copy link
Member

@BlueberryKing BlueberryKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alepouna
Copy link
Member

alepouna commented Nov 2, 2023

QA Report

Discord: alepouna
Object of testing: #8279
Tier of Testing : 1
Date : 02/11/2023

Testing Process:

  • Insert a valid Hoppie station
  • [PASS] Observe page refreshing without any other input

Testing Results:
Passed

@BlueberryKing BlueberryKing enabled auto-merge (squash) November 2, 2023 11:08
@BlueberryKing BlueberryKing merged commit 321216d into flybywiresim:master Nov 2, 2023
5 checks passed
@2hwk 2hwk added this to the v0.11.2 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants