-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for deploymentLabels #1707
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR! could you also update the chart's README accordingly. i see that we missed out on the docs for podLabels
, so we can do both in this PR as well
Could this be used to address the issues raised in #1312? |
@KrylixZA i'm investigating that. i'd say if that needs to be addressed, we shall do so in a different PR, since they're completely different things. |
@aryan9600 README has been updated. Should I make a similar update to docs/gitbook/install/flagger-install-on-kubernetes.md? |
Sure, that'd be great. Could you also specify the |
done |
@aryan9600 Any other changes needed? |
@aryan9600 @stefanprodan - Just following up on this PR. Are any other changes needed? Thanks for taking the time to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @quintonm and apologies for the delay
@aryan9600 - How do I trigger a build? It looks like one is needed before the PR can be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 39.27% 39.30% +0.03%
==========================================
Files 284 284
Lines 22379 22391 +12
==========================================
+ Hits 8789 8801 +12
Misses 12643 12643
Partials 947 947 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quintonm could you squash all the commits into one and then force push?
e8cf645
to
87db1a3
Compare
Signed-off-by: quintonm <[email protected]>
@aryan9600 done |
@aryan9600 Is there anything else that I need to do before |
This PR adds support for configuring additional labels for the deployment using
deploymentLabels
invalues.yaml
.