job-ingest: fix cleanup when a pipeline worker process fails #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some functions with long parameter lists are broken using a block format, but most of the Flux codebase breaks parameters one per line. Break long parameter lists with one parameter per line.
Problem: When a subprocess being used as a worker in the job-ingest pipeline fails, pending futures may not be fulfilled since the subprocess is immediately destroyed. Call worker_unexpected_exit() when a worker subprocess fails so that any pending requests are failed. This completely cleans up the worker so that no request hang and a new worker will be started, hopefully resolving the problem instead of hanging the ingest module.
garlick
approved these changes
Nov 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #5549 +/- ##
=======================================
Coverage 83.43% 83.43%
=======================================
Files 487 487
Lines 82286 82287 +1
=======================================
+ Hits 68657 68660 +3
+ Misses 13629 13627 -2
|
|
Thanks! I've set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another piece of the workaround for #5518.
If the buffer for a subprocess on the server side becomes full and therefore a write fails, libsubprocess currently treats this as fatal error, kills the subprocess and returns
FLUX_SUBPROCESS_FAILEDas subprocess state.If this occurs for a job-ingest worker, then any futures still in the queue will never be fulfilled and job submissions will appear to hang.
This PR just adds a call to
worker_unexpected_exit()for failed worker subprocesses so that any pending futures are fulfilled with error.