Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a function to get DYAD file metadata #54

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Adds a function to get DYAD file metadata #54

merged 3 commits into from
Nov 9, 2023

Conversation

ilumsden
Copy link
Collaborator

This PR adds a new function to the Core library: dyad_get_metadata. This function accepts a file path as input, and, if metadata about that file is found in the Flux KVS, it will return that metadata to the user.

Additionally, this PR adds Python bindings to the new dyad_get_metadata function.

Due to the Python binding, this PR depends on #27

@ilumsden ilumsden added the enhancement New feature or request label Oct 27, 2023
@ilumsden ilumsden self-assigned this Oct 27, 2023
@ilumsden
Copy link
Collaborator Author

@JaeseungYeom @hariharan-devarajan this PR is ready for review. I'm not sure why GitHub is complaining about a conflict in bindings.py. All that's changed is that I've added some things, and I replaced import os with import weakref.

@JaeseungYeom
Copy link
Contributor

Can you list what the changes are?
I am not sure if you are adding a new function or replacing an existing function. The latter relies on the future for a reason but that seems to be absent in the new function.

ilumsden
ilumsden commented Nov 2, 2023
View reviewed changes
src/core/dyad_core.c Outdated Show resolved Hide resolved
JaeseungYeom
JaeseungYeom reviewed Nov 2, 2023
View reviewed changes
src/core/dyad_core.c Outdated
uint32_t* owner_rank,
flux_future_t** f)
DYAD_CORE_FUNC_MODS dyad_rc_t dyad_kvs_read (const dyad_ctx_t* ctx,
const char* topic,
Copy link
Contributor

@JaeseungYeom JaeseungYeom Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the restrict keyword for both ctx and topic

@ilumsden ilumsden force-pushed the check_metadata_api branch 2 times, most recently from 0971943 to f5776eb Compare November 3, 2023 18:03
JaeseungYeom
JaeseungYeom reviewed Nov 6, 2023
View reviewed changes
src/core/dyad_core.c Outdated Show resolved Hide resolved
JaeseungYeom
JaeseungYeom reviewed Nov 6, 2023
View reviewed changes
src/core/dyad_core.c Outdated Show resolved Hide resolved
JaeseungYeom
JaeseungYeom reviewed Nov 6, 2023
View reviewed changes
src/core/dyad_core.c Outdated Show resolved Hide resolved
@hariharan-devarajan
Copy link
Collaborator

@ilumsden do u know why the CI failed here?

@ilumsden
Copy link
Collaborator Author

ilumsden commented Nov 8, 2023

It seems to be an error from apt. No clue why that would happen. None of my changes touch the tank file, so nothing I've done should cause this

@hariharan-devarajan
Copy link
Collaborator

hariharan-devarajan commented Nov 8, 2023 •
edited
Loading

add sudo apt-get update before u do install.

@JaeseungYeom JaeseungYeom merged commit 92ac11e into flux-framework:main Nov 9, 2023
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaeseungYeom JaeseungYeom JaeseungYeom left review comments

@hariharan-devarajan hariharan-devarajan Awaiting requested review from hariharan-devarajan

Assignees

@ilumsden ilumsden

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilumsden @JaeseungYeom @hariharan-devarajan