Fix unbounded memory usage #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueb2
force-pushed
the
ios/memory-usage
branch
from
a950049 to
f3e40c2
Compare
|
This may make the clearUploads interface useless for iOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CacheStreamHandler and UploadResultDatabase would play hand in hand to continuously increase memory usage. After every init, the UploadResultDatabase would add into the CacheStreamHandler's cache every taskId and map pair ever processed since the last clearUploads. During app lifecycle, CacheStreamHandler would build up its cache on a per event basis. This means memory usage is always as big as all previous events' taskIds and metadata.
To me, the UploadResultDatabase doesn't serve any purpose. Arguably, this is a feature, not a bug. Since I have a listener installed at app init for results, I don't ever want a build up or recall of previous events. There is probably a less heavy handed approach for this, but this fixes my "memory leak" problems. #80