Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR template that explains updating tests.version #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matanlurey
Copy link
Contributor

Part of flutter/flutter#162048.

This can be of course tweaked and improved.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some clarification.

.github/pull_request_template.md Outdated Show resolved Hide resolved
@zanderso zanderso requested a review from Piinks January 23, 2025 00:19
@matanlurey
Copy link
Contributor Author

Ping

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the content from the normal PR template? I think this will override the default like the prelaunch checklist here: #420

IIRC the repo falls back to the org default in the flutter/.github repo here: https://github.com/flutter/.github/blob/main/PULL_REQUEST_TEMPLATE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants