-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk
constraints
#8345
base: main
Are you sure you want to change the base?
Conversation
… to match example apps
|
packages/.ci/legacy_project/all_packages/android/gradle/wrapper/gradle-wrapper.properties Line 6 in 864e6be
Bump like #6742 |
Error now is that the legacy variant is using a lower version of AGP and needs 8.1
|
else ...<String, List<String>>{ | ||
'compileSdkVersion': <String>['compileSdk 34'], | ||
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From triage: Is one of these the legacy file? If so, can we make that file use compileSdk 35
(just copying discussion from internal conversation).
else ...<String, List<String>>{ | ||
'compileSdkVersion': <String>['compileSdk 34'], | ||
'compileSdkVersion': <String>['compileSdk flutter.compileSdkVersion'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we eliminate this conditional logic by just using compileSdk = 35
in both cases? I think that is valid Groovy as well as Kotlin
A few dependency bumps are failing due to the all_packages test targeting a lower version of Android SDK than the example apps. Instead of hardcoding an SDK version which needs to be updated manually (https://github.com/flutter/packages/pull/7891/files#r1815169527), instead use flutter.compileSdkVersion, similar to #3847.
Unblocks attempts to increase dependencies versions that require SDK 35 or higher
#7985
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.