refactor: pr feedback on tests for firebase_deep_link client

flutter · Sep 25, 2024 · 84f9219 · 84f9219
1 parent a9207df
commit 84f9219
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 45 deletions.
diff --git a/...ackages/deep_link_client/firebase_deep_link_client/lib/src/firebase_deep_link_client.dart b/...ackages/deep_link_client/firebase_deep_link_client/lib/src/firebase_deep_link_client.dart
@@ -10,9 +10,8 @@ import 'package:firebase_dynamic_links/firebase_dynamic_links.dart';
 /// {@endtemplate}
 class FirebaseDeepLinkClient implements DeepLinkClient {
   /// {@macro firebase_deep_link_client}
-  FirebaseDeepLinkClient({FirebaseDynamicLinks? firebaseDynamicLinks})
-      : _firebaseDynamicLinks =
-            firebaseDynamicLinks ?? FirebaseDynamicLinks.instance;
+  FirebaseDeepLinkClient({required FirebaseDynamicLinks firebaseDynamicLinks})
+      : _firebaseDynamicLinks = firebaseDynamicLinks;
 
   final FirebaseDynamicLinks _firebaseDynamicLinks;
 

diff --git a/...kages/deep_link_client/firebase_deep_link_client/test/firebase_deep_link_client_test.dart b/...kages/deep_link_client/firebase_deep_link_client/test/firebase_deep_link_client_test.dart
@@ -1,7 +1,6 @@
 // ignore_for_file: deprecated_member_use
 
 import 'dart:async';
-import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_core_platform_interface/firebase_core_platform_interface.dart';
 import 'package:firebase_deep_link_client/firebase_deep_link_client.dart';
 import 'package:firebase_dynamic_links/firebase_dynamic_links.dart';
@@ -53,55 +52,18 @@ void main() {
         final client =
             FirebaseDeepLinkClient(firebaseDynamicLinks: dynamicLinks);
 
-        expect(
-          client.deepLinkStream,
-          emitsInOrder(
-            <Uri>[expectedUri1, expectedUri1, expectedUri2, expectedUri1],
-          ),
-        );
-
         onLinkStreamController
           ..add(PendingDynamicLinkData(link: expectedUri1))
           ..add(PendingDynamicLinkData(link: expectedUri1))
           ..add(PendingDynamicLinkData(link: expectedUri2))
           ..add(PendingDynamicLinkData(link: expectedUri1));
-      });
-    });
-
-    group('with default FirebaseDynamicLinks', () {
-      setUp(() {
-        TestWidgetsFlutterBinding.ensureInitialized();
-
-        final mock = MockFirebaseCore();
-        Firebase.delegatePackingProperty = mock;
 
-        final platformApp = FirebaseAppPlatform(
-          'testAppName',
-          const FirebaseOptions(
-            apiKey: 'apiKey',
-            appId: 'appId',
-            messagingSenderId: 'messagingSenderId',
-            projectId: 'projectId',
+        expect(
+          client.deepLinkStream,
+          emitsInOrder(
+            <Uri>[expectedUri1, expectedUri1, expectedUri2, expectedUri1],
           ),
         );
-
-        when(() => mock.apps).thenReturn([platformApp]);
-        when(() => mock.app(any())).thenReturn(platformApp);
-        when(
-          () => mock.initializeApp(
-            name: any(named: 'name'),
-            options: any(named: 'options'),
-          ),
-        ).thenAnswer((_) => Future.value(platformApp));
-      });
-
-      tearDown(() {
-        Firebase.delegatePackingProperty = null;
-      });
-
-      test('can be instantiated', () async {
-        await Firebase.initializeApp();
-        expect(FirebaseDeepLinkClient.new, returnsNormally);
       });
     });
   });