Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support to skip the validation of indirectly related resources involved in webhook mutating #4473

Conversation

Syspretor
Copy link
Collaborator

@Syspretor Syspretor commented Jan 14, 2025

For performance and stability considerations, we introduced a caching layer in the design of the webhook. However, this leads to cache update delays in scenarios involving large-scale concurrent resource creation, resulting in resource validation failures, even though the resource state in the API server is already correct. This PR provides an annotation in the pod, allowing for the specification of certain pods where, during the webhook mutation process, the validation of indirectly related resources can be skipped. This approach helps to both avoid issues with resource state updates due to caching delays in large-scale concurrent scenarios and optimize the performance of mutations.

apiVersion: v1
kind: Pod
metadata:
  name: demo
  annotations:
    sidecar.fluid.io/skip-precheck

@Syspretor Syspretor force-pushed the feature/support-skip-resource-check-in-webhook branch 6 times, most recently from 03d5e48 to daa0864 Compare January 15, 2025 06:20
…es involved in webhook mutating

Signed-off-by: jiuyu <[email protected]>
@Syspretor Syspretor force-pushed the feature/support-skip-resource-check-in-webhook branch from daa0864 to 6ae1975 Compare January 15, 2025 06:30
Copy link

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Jan 15, 2025

/test fluid-e2e

@cheyang
Copy link
Collaborator

cheyang commented Jan 16, 2025

/retest

Copy link

fluid-e2e-bot bot commented Jan 16, 2025

@Syspretor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fluid-e2e 6ae1975 link true /test fluid-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheyang cheyang merged commit 4353d62 into fluid-cloudnative:master Jan 16, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants