in_calyptia_fleet: log info about config pulled from API #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearpidgeon
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
nuclearpidgeon
force-pushed
the
fleet-logging
branch
from
ff5b850 to
ed2382c
Compare
|
@pwhelan FYI (given you seem to be the main name in the git blame for this fleet input plugin...) |
Also set local timestamp to -1 on startup as otherwise it could end up being read as an uninitialised value Signed-off-by: Stewart Webb <[email protected]>
nuclearpidgeon
force-pushed
the
fleet-logging
branch
from
ed2382c to
fb0ff73
Compare
Indeed I am. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with large numbers of unattended servers, it is very useful to know for sure when they have pulled what version of fleet config. Currently the only way that the pull of a new version can be known is by second-hand inference of the "changing to config dir" log messages, which aren't a reliable source for this anyway as they are always logged on Fluentbit startup.
Testing
Documentation
Documentation not required for this feature
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.