-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka #9860
Merged
patrick-stephens
merged 8 commits into
master
from
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
Jan 23, 2025
Merged
package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka #9860
patrick-stephens
merged 8 commits into
master
from
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
Jan 23, 2025
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
January 22, 2025 08:51
Do we need this in the container images too? |
Yeah, good point. We need to add it into them. |
…afka Signed-off-by: Hiroshi Hatake <[email protected]>
…OAuth/OICD Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
changed the title
package: distro: Install libcurl development package for oauthoicd on rdkafka
package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka
Jan 23, 2025
cosmo0920
force-pushed
the
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
branch
6 times, most recently
from
January 23, 2025 07:26
26c12b1
to
d3b3b18
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
branch
from
January 23, 2025 07:38
d3b3b18
to
96babaf
Compare
patrick-stephens
approved these changes
Jan 23, 2025
patrick-stephens
deleted the
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
branch
January 23, 2025 11:17
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because libkafka's SASL OAUTHBEARER mechanism depends on libcurl and OpenSSL.
We already installed a development package of OpenSSL in each of building containers but we didn't install a development package of libcurl.
This leads for degraded usability for rdkafka library and it makes not to be able to use SASL OAUTHBEARER mechanism on kafka plugins like below with #9859 patch:
This PR aims to fix this issue.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.