Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst: Add libaom based AV1 decoder #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndufresne
Copy link
Contributor

This is useful to GStreamer project in order to ensure nothing in GStreamer prevents libaom from working correctly. This decoder fully passes AV1-TEST-VECTORS, CHROMIUM-8bit-AV1-TEST-VECTORS and CHROMIUM-10bit-AV1-TEST-VECTORS. The Argon suites have been ignored for now.

This is useful to GStreamer project in order to ensure nothing in
GStreamer prevents libaom from working correctly. This decoder fully
passes AV1-TEST-VECTORS, CHROMIUM-8bit-AV1-TEST-VECTORS and
CHROMIUM-10bit-AV1-TEST-VECTORS. The Argon suites have been ignored for now.
@ndufresne ndufresne force-pushed the aom-gstreamer-decoder branch from bc46388 to c0f5ddf Compare January 24, 2025 16:10
@ndufresne
Copy link
Contributor Author

We should perhaps make the new commit message check verbose in the CI ?

@mdimopoulos
Copy link
Contributor

We should perhaps make the new commit message check verbose in the CI ?

Like a dedicated workflow? How do you mean?

@ndufresne
Copy link
Contributor Author

We should perhaps make the new commit message check verbose in the CI ?

Like a dedicated workflow? How do you mean?

No, simpler then that, when it fails it tells the user to add --verbose, and provide no indication of what was wrong with the commit message. So I was wondering if we cannot just always pass --verbose ?

@rsanchez87
Copy link
Contributor

rsanchez87 commented Jan 25, 2025

We should perhaps make the new commit message check verbose in the CI ?

Like a dedicated workflow? How do you mean?

No, simpler then that, when it fails it tells the user to add --verbose, and provide no indication of what was wrong with the commit message. So I was wondering if we cannot just always pass --verbose ?

Yes, we can do it, but I think bad commit message is reported... is not enough? link with conventional commit too...

image

With --verbose option I see info for me not very relevant like:

- hook id: conventional-pre-commit
- duration: 0.05s
- exit code: 1

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants