-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COM-12614 #231
base: master
Are you sure you want to change the base?
COM-12614 #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort, the report looks much much better and more complete.
I have several requests related to the presentation and layout of the information, let me know if there are any doubts.
## H.265/HEVC | ||
### H.266/VVC Intel | ||
|
||
`./fluster.py run -d VVdeC-H266 GStreamer-H.266-VVdec-Gst1.0 FFmpeg-H.266 -ts JVET-VVC_draft6 -s` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the list below i see no results for VVdeC-H266
and GStreamer-H.266-VVdec-Gst1.0
.
- for the first one: did you build the executable of the reference decoder using the Makefile (target:
h266_reference_decoder
)? - for the second one: your GStreamer version might not be new enough to support the decoder.
If this is the case can you
- build the ref decoder and add the test results below?
- simply remove the decoder from this line, otherwise add the test results below?
|Test|JCT-VT-H.265|GStreamer-H.265-VAAPI-Gst1.0|FFmpeg-H.265-VAAPI|FFmpeg-H.265| | ||
`./fluster.py run -d JCT-VT-H.265 GStreamer-H.265-VAAPI-Gst1.0 FFmpeg-H.265-VAAPI FFmpeg-H.265 -ts JCT-VC-HEVC_V1 -s` | ||
|
||
|Test|FFmpeg-H.265|FFmpeg-H.265-VAAPI|GStreamer-H.265-VAAPI-Gst1.0|JCT-VT-H.265| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not difficult, can you maintain the same order as before in the test results?
Reference decoder, then GStreamer, then FFmpeg.
|
||
Lenovo Thinkpad T490 using i965 driver: | ||
Lenovo ThinkPad T15p Gen 2i using iHD driver: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add information about the Gstreamer and FFmpeg versions that were used during testing?
|
||
### H.265/HEVC Intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a subtitle that specifies the test suite. In the future we might want to add results for other test suites
|
||
`./fluster.py run -d JCT-VT-H.264 GStreamer-H.264-VAAPI-Gst1.0 FFmpeg-H.264-VAAPI FFmpeg-H.264 -ts JVT-AVC_V1 -s` | ||
|
||
|Test|JCT-VT-H.264|GStreamer-H.264-VAAPI-Gst1.0|FFmpeg-H.264-VAAPI|FFmpeg-H.264| | ||
|Test|FFmpeg-H.264|FFmpeg-H.264-VAAPI|GStreamer-H.264-VAAPI-Gst1.0|JCT-VT-H.264| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not difficult, can you maintain the same order as before in the test results?
Reference decoder, then GStreamer, then FFmpeg.
|
||
`./fluster.py run -d JCT-VT-H.265 GStreamer-H.265-VAAPI-Gst1.0 FFmpeg-H.265-VAAPI GStreamer-H.265-NVDEC-Gst1.0 FFmpeg-H.265-VDPAU FFmpeg-H.265 -ts JCT-VC-HEVC_V1 -s` | ||
|
||
|Test|FFmpeg-H.265|FFmpeg-H.265-VAAPI|FFmpeg-H.265-VDPAU|GStreamer-H.265-NVDEC-Gst1.0|GStreamer-H.265-VAAPI-Gst1.0|JCT-VT-H.265| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not too much maintain original decoder order, reference, then gstreamer, then ffmpeg
|
||
|
||
### H.265/HEVC Nvidia | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for Intel, add a subtitle to indicate the name of the test suite
|
||
|
||
### H.264/AVC Nvidia | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for Intel, add a subtitle to indicate the name of the test suite
|
||
### H.264/AVC Nvidia | ||
|
||
`./fluster.py run -d JCT-VT-H.264 GStreamer-H.264-VAAPI-Gst1.0 FFmpeg-H.264-VAAPI GStreamer-H.264-NVDEC-Gst1.0 FFmpeg-H.264-VDPAU FFmpeg-H.264 -ts JVT-AVC_V1 -s` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for H265 decoder previously, remove VAAPI based ones as we don't know which GPU they are using internally.
|
||
`./fluster.py run -d JCT-VT-H.264 GStreamer-H.264-VAAPI-Gst1.0 FFmpeg-H.264-VAAPI GStreamer-H.264-NVDEC-Gst1.0 FFmpeg-H.264-VDPAU FFmpeg-H.264 -ts JVT-AVC_V1 -s` | ||
|
||
|Test|FFmpeg-H.264|FFmpeg-H.264-VAAPI|FFmpeg-H.264-VDPAU|GStreamer-H.264-NVDEC-Gst1.0|GStreamer-H.264-VAAPI-Gst1.0|JCT-VT-H.264| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintain decoder order if it's not too much effort
Intel and Nvidia sections were added, h266 was added also and h265 and h264 were updated.