Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a test suite in fluster for H265 SHVC functionality set #184

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Generate a test suite in fluster for H265 SHVC functionality set #184

merged 2 commits into from
Jul 30, 2024

Conversation

rsanchez87
Copy link
Contributor

No description provided.

@rsanchez87 rsanchez87 requested a review from mdimopoulos July 29, 2024 09:51
mdimopoulos
mdimopoulos reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the changes in the PR cause regressions with the generation of some test suites. I compared the .json files of the repo with the ones generated locally on my machine and i found differences in

JCT-VC-MV-HEVC.json, JVET-VVC_draft6.json, JVT-AVC_V1.json, JVT-Professional_profiles_V1.json

Most are related to the checksums themselves, there are others too. More details in the related task

@rsanchez87
Copy link
Contributor Author

Some the changes in the PR cause regressions with the generation of some test suites. I compared the .json files of the repo with the ones generated locally on my machine and i found differences in

JCT-VC-MV-HEVC.json, JVET-VVC_draft6.json, JVT-AVC_V1.json, JVT-Professional_profiles_V1.json

Most are related to the checksums themselves, there others too. More details in the related task

Ok, thanks, I'm going to check, maybe some change in find_by_ext function in this PR

@rsanchez87 rsanchez87 requested a review from mdimopoulos July 30, 2024 09:12
@rsanchez87
Copy link
Contributor Author

Some the changes in the PR cause regressions with the generation of some test suites. I compared the .json files of the repo with the ones generated locally on my machine and i found differences in
JCT-VC-MV-HEVC.json, JVET-VVC_draft6.json, JVT-AVC_V1.json, JVT-Professional_profiles_V1.json
Most are related to the checksums themselves, there others too. More details in the related task

Ok, thanks, I'm going to check, maybe some change in find_by_ext function in this PR

Bug created, is not related with this PR

mdimopoulos
mdimopoulos approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rsanchez87 rsanchez87 merged commit 56fc23e into master Jul 30, 2024
3 checks passed
@rsanchez87 rsanchez87 deleted the COM-10938 branch July 30, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimopoulos mdimopoulos mdimopoulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanchez87 @mdimopoulos