Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a test suite for H264 SVC group #177

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Create a test suite for H264 SVC group #177

merged 8 commits into from
Jul 22, 2024

Conversation

rsanchez87
Copy link
Contributor

No description provided.

@rsanchez87 rsanchez87 force-pushed the COM-10838 branch 5 times, most recently from 02032fa to 21bb86f Compare July 10, 2024 14:35
@rsanchez87 rsanchez87 requested a review from mdimopoulos July 18, 2024 09:54
mdimopoulos
mdimopoulos requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests to verify that your changes and my suggestions do not cause any regression in test suites that were already present previously.
Results were positive.

scripts/gen_jvet_jctvc.py Outdated Show resolved Hide resolved
scripts/gen_jvet_jctvc.py Outdated Show resolved Hide resolved
scripts/gen_jvet_jctvc.py Outdated Show resolved Hide resolved
scripts/gen_jvet_jctvc.py Outdated Show resolved Hide resolved
scripts/gen_jvet_jctvc.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
@rsanchez87 rsanchez87 requested a review from mdimopoulos July 22, 2024 07:15
mdimopoulos
mdimopoulos requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor change requests, my initial comments might not have been clear enough

scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
scripts/gen_jvt.py Outdated Show resolved Hide resolved
@rsanchez87 rsanchez87 requested a review from mdimopoulos July 22, 2024 09:16
mdimopoulos
mdimopoulos approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Remember to either rebase or squash and merge.

@rsanchez87 rsanchez87 merged commit 2790984 into master Jul 22, 2024
3 checks passed
@rsanchez87 rsanchez87 deleted the COM-10838 branch July 22, 2024 09:37
@mdimopoulos mdimopoulos mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimopoulos mdimopoulos mdimopoulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanchez87 @mdimopoulos