perf(polygons): cull labels separately, and cache TextPainter
#1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatz
force-pushed
the
faster_polygon_labels
branch
from
cdbadf9 to
564f65a
Compare
JaffaKetchup
requested changes
Nov 3, 2023
…e polygons, deriving pixel bounds from polygon's latlng bounds, and most importantly cache the TextPainter.
ignatz
force-pushed
the
faster_polygon_labels
branch
from
564f65a to
1d29456
Compare
JaffaKetchup
changed the title
TextPainter
JaffaKetchup
changed the title
TextPainterTextPainter
JaffaKetchup
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ease of reviewing, I pulled the "polygon label"-only changes out of #1714 AND add TextPainter caching (which is actually the biggest cost reduction)
I could also add the TextPainter caching to #1714 but maybe we don't make that one even more sprawling. I'd suggest to review this one first and then I'll update #1714 .