Fix incorrect framerate when loading bidirectional SBX files #1452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I realized that the frame rate when loading a bidirectional SBX file was half of what it should be. This is because in
sbx_meta_data
, I assumed thatinfo['recordsPerBuffer']
would be half for bidirectional files, so dividing by it when computing the frame rate would give 2X the rate for these files, as it should be. But I must have forgotten I was doing this, because insbx_shape
(which is called first) I modifyinfo[recordsPerBuffer]
to match the X size. This is unnecessary since I already have the X size ininfo['sz'][0]
.Along the way, I also made a few miscellaneous changes to eliminate type errors according to pyright (some important for documentation, such as the requirement that subindices be sequences, not just iterables).
Type of change
Please delete options that are not relevant.
Has your PR been tested?
Yes, I added a test to test_sbx.py that loads a new bidirectional test movie and ensures the sample rate is correct. I also added checks for the sample rates of the other test movies.