Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --filesystem=xdg-cache/thumbnails #169

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Add --filesystem=xdg-cache/thumbnails #169

merged 2 commits into from
Dec 29, 2024

Conversation

travier
Copy link
Member

@travier travier commented Dec 16, 2024

Grant access to thumbnail cache folder in home directory. This is safe as Gwenview already has access to everything (host) right now as it's not fully portal aware yet.

Fixes: #168

@flathubbot
Copy link
Contributor

Started test build 168756

@flathubbot
Copy link
Contributor

Build 168756 failed

Grant access to thumbnail cache folder in home directory.
This is safe as Gwenview already has access to everything (host) right
now as it's not fully portal aware yet.

Fixes: #168
@flathubbot
Copy link
Contributor

Started test build 168761

@flathubbot
Copy link
Contributor

Build 168761 failed

@travier
Copy link
Member Author

travier commented Dec 16, 2024

Looks like we will need an exception: https://docs.flathub.org/docs/for-app-authors/linter/#finish-args-unnecessary-xdg-cache-subdir-mode-access

{
    "errors": [
        "finish-args-unnecessary-xdg-cache-thumbnails-rw-access"
    ],
    "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
}

@Justinzobel
Copy link
Member

Created flathub-infra/flatpak-builder-lint#551 for exception.

@Justinzobel
Copy link
Member

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.kde.gwenview.

@flathubbot
Copy link
Contributor

Started test build 170991

@flathubbot
Copy link
Contributor

Build 170991 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/154089/org.kde.gwenview.flatpakref

@flathubbot
Copy link
Contributor

Started test build 171000

@flathubbot
Copy link
Contributor

Build 171000 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/154098/org.kde.gwenview.flatpakref

@Justinzobel Justinzobel merged commit eb58a24 into master Dec 29, 2024
1 check passed
@Justinzobel Justinzobel deleted the master-cache branch December 29, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use existing thumbnail cache folder
3 participants