New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] fix(tags): sanitize page param in `Tag` #4170

Open

rob006 wants to merge 1 commit into flarum:1.x from rob006:sanitize-page

Contributor

rob006 commented Jan 27, 2025

Fix errors for requests like https://discuss.flarum.org/t/sandbox?page=%27nvOpzp;%20AND%201=1%20OR%20(%3C%27%22%3EiKO))

PHP Warning:  A non-numeric value encountered in vendor/flarum/tags/src/Content/Tag.php on line 84

Uses the same solution as in:

framework/framework/core/src/Forum/Content/Index.php

Line 70 in 1d27f62

$page = max(1, intval(Arr::pull($queryParams, 'page')));


          Sanitize page in Tag

88989a7

rob006 requested a review from a team as a code owner

January 27, 2025 20:17

rob006 changed the title ~~Sanitize page param in Tag~~ [1.x] fix(tags): sanitize page param in Tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet