This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
Updated matrix.copy to applyMatrix
#157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toxicFork I submitted this pull request, however I saw that the old code used this function and then it was changed in January with this commit: 81142f8#diff-77134061d2e13d41e19e16ed94cf8cf6 Is there a reason this was changed from Thanks! |
|
I still need to investigate this (sorry about taking so long) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to pass in a
Matrix4via thematrixprop, it seemed that myObject3Dwasn't applying it at all. After updating it to useapplyMatrix, the matrix transformation seemed to work fine.