Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu item to open the JS scripts in DevTools debugger #5295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

canova
Copy link
Member

@canova canova commented Jan 7, 2025

This is a deploy preview for Bug 1925391.

It adds a context menu item for call node context menu to open the JS source code in the devtools debugger directly if the tab and browser connection still exists.

Unfortunately it's not possible to simply give a deploy preview. It needs to be a newly captured profile since it relies on the browser web channel connection to be alive.

The recent Firefox Nightly should have the web channel now. So you use any nightly version that includes the patch from Bug 1925391. Here's how to test it locally:

  • Go to about:config, change devtools.performance.recording.ui-base-url to https://deploy-preview-5295--perf-html.netlify.app.
  • Go to about:profiling and enable the JS Execution Tracing feature.
  • Start the profiler using profiler popup.
  • Go to any website, e.g. https://en.wikipedia.org/wiki/Main_Page
  • Capture the profile.
  • Go to flame graph in the opened profile and right click any JS frame.
  • Click Show the function in DevTools.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 14.81481% with 46 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (f07cfdc) to head (9a4fb2e).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/components/shared/CallNodeContextMenu.js 15.90% 31 Missing and 6 partials ⚠️
src/app-logic/browser-connection.js 20.00% 3 Missing and 1 partial ⚠️
src/test/fixtures/mocks/web-channel.js 0.00% 3 Missing ⚠️
src/app-logic/web-channel.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5295      +/-   ##
==========================================
- Coverage   86.07%   85.94%   -0.13%     
==========================================
  Files         311      311              
  Lines       29657    29710      +53     
  Branches     8196     8211      +15     
==========================================
+ Hits        25528    25535       +7     
- Misses       3547     3586      +39     
- Partials      582      589       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canova canova force-pushed the js-tracer-source branch 2 times, most recently from 7a72f9a to d8cd9ec Compare January 23, 2025 12:40
@canova canova marked this pull request as ready for review January 23, 2025 12:42
@canova canova requested a review from a team as a code owner January 23, 2025 12:42
@canova canova requested review from julienw and a team January 23, 2025 12:46
@canova canova changed the title [deploy preview] Add a context menu item to open the JS scripts in DevTools debugger Add a context menu item to open the JS scripts in DevTools debugger Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants