Fix some test and non-test warnings #5294
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5294 +/- ##
==========================================
- Coverage 88.61% 88.61% -0.01%
==========================================
Files 308 308
Lines 28125 28122 -3
Branches 7621 7620 -1
==========================================
- Hits 24923 24920 -3
Misses 2987 2987
Partials 215 215 ☔ View full report in Codecov by Sentry. |
| // As of React 18, If the action dispatch isn't delayed, the component will | ||
| // get rerendered with the redux changes before the react state changes are | ||
| // applied. As a result CurrentProfileUploadedInformationLoader could reset | ||
| // the profile information faster than this metaInfoPanelState was applied, | ||
| // and we were getting an error in _renderMetaInfoButton. | ||
| // Using requestAnimationFrame ensures that this component's state | ||
| // is properly applied before changing the redux state. Note that if we were | ||
| // using a function component, we could use useLayoutEffect instead. | ||
| // Note that this might not be necessary in future versions of React or | ||
| // React-Redux, so be sure to revisit this choice in the future. | ||
| requestAnimationFrame(() => { | ||
| this.props.profileRemotelyDeleted(); | ||
| }); |
There was a problem hiding this comment.
Hm this is a bit hacky, but if it works it's okay for me I guess. Do we always know for sure that requestAnimationFrame will be enough for it to update the state?
Another solution might be to have a componentDidUpdate that checks if the metaInfoPanelState state has changed, and calls profileRemotelyDeleted only if it's changed.
julienw
force-pushed
the
fix-some-test-warnings
branch
from
48da62f to
61f1010
Compare
|
Hey @canova , I updated the code like we discussed, this looks better to me, thanks for the feedback! |
This fixes 2 warnings:
button.clickinstead offireEvent.click. The former isn't wrapped byactwhile the latter is.