-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute cpuRatio values when computing the derived thread #5288
Open
mstange
wants to merge
5
commits into
firefox-devtools:main
Choose a base branch
from
mstange:push-uvqxurtzkpsk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
2 times, most recently
from
January 2, 2025 22:41
128fdbf
to
1f72810
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5288 +/- ##
==========================================
- Coverage 86.02% 86.02% -0.01%
==========================================
Files 311 312 +1
Lines 29791 29750 -41
Branches 8217 8191 -26
==========================================
- Hits 25629 25592 -37
+ Misses 3576 3572 -4
Partials 586 586 ☔ View full report in Codecov by Sentry. |
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
from
January 3, 2025 20:26
1f72810
to
22e9b62
Compare
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
4 times, most recently
from
January 20, 2025 18:30
e5178f9
to
7aeaf62
Compare
mstange
changed the title
In the derived Thread type, make it clear that threadCPUDelta doesn't have null values
Compute cpuRatio values when computing the derived thread
Jan 20, 2025
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
4 times, most recently
from
January 23, 2025 18:55
2fd1aaf
to
edb7649
Compare
This avoids a circular dependency between cpu.js, process-profile.js and profile-data.js, because in the next commit I want to use a function from cpu.js in profile-data.js.
It looks like I forgot to update this comment when I changed this function to no longer use the interval.
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
from
January 23, 2025 18:56
edb7649
to
fa5b453
Compare
This makes it clearer that, with time-based CPU deltas, you can have profiles that never hit 100% CPU usage.
mstange
force-pushed
the
push-uvqxurtzkpsk
branch
from
January 23, 2025 19:23
dac5897
to
254026d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
processThreadCPUDelta
makes it so that thethreadCPUDelta
column doesn't have any null values. However, the type of thethreadCPUDelta
column still looks as if values could be null.Now that we have a derived
Thread
type, we can change the type so that it expresses that the values can't be null. So we move the call toprocessThreadCPUDelta
a bit earlier in the derivation pipeline so that all the types work out.Even better, we can compute CPU ratios at this point, and not even store the "clamped and non-null cpu delta" values.
And since we're doing that, I'm changing the behavior for null cpu delta values: Rather than using the closest non-null cpu delta and spreading it over a potentially-different sample time delta, just set the cpu ratio to 1. The only known cause of null values (other than the first value, which we ignore) is the base profiler, and we want CPU percentage to be reported as 100% during the base profiler time.
Fixes #4072.