-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for recursive @compiled
without materialization
#83
Merged
hameerabbasi
merged 12 commits into
finch-tensor:main
from
hameerabbasi:recursive-compiled
Dec 17, 2024
Merged
Allow for recursive @compiled
without materialization
#83
hameerabbasi
merged 12 commits into
finch-tensor:main
from
hameerabbasi:recursive-compiled
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
force-pushed
the
recursive-compiled
branch
from
December 12, 2024 10:07
3f29c1a
to
d93f2f0
Compare
hameerabbasi
force-pushed
the
recursive-compiled
branch
from
December 12, 2024 10:39
a170c99
to
b89a2e5
Compare
hameerabbasi
force-pushed
the
recursive-compiled
branch
from
December 12, 2024 11:10
b89a2e5
to
cdc51d3
Compare
mtsokol
reviewed
Dec 12, 2024
I'll review it once it's rebased. |
hameerabbasi
force-pushed
the
recursive-compiled
branch
from
December 12, 2024 17:13
8c1b143
to
af6b9c9
Compare
Codecov ReportAttention: Patch coverage is
|
mtsokol
requested changes
Dec 16, 2024
mtsokol
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just typing nitpicks and it's ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@compiled
.pre-commit autoupdate