Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for recursive @compiled without materialization #83

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

hameerabbasi
Copy link
Collaborator

  • Materialize only in outermost nested @compiled.
  • pre-commit autoupdate

@mtsokol
Copy link
Member

mtsokol commented Dec 12, 2024

I'll review it once it's rebased.

@hameerabbasi hameerabbasi requested a review from mtsokol December 16, 2024 09:41
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/finch/compiled.py 88.09% 5 Missing ⚠️
src/finch/tensor.py 75.00% 3 Missing ⚠️
src/finch/io.py 50.00% 1 Missing ⚠️
src/finch/julia.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/finch/dtypes.py 84.37% <ø> (ø)
src/finch/errors.py 100.00% <ø> (ø)
src/finch/io.py 70.83% <50.00%> (ø)
src/finch/julia.py 87.50% <50.00%> (ø)
src/finch/tensor.py 90.75% <75.00%> (-0.13%) ⬇️
src/finch/compiled.py 86.76% <88.09%> (-3.94%) ⬇️

src/finch/tensor.py Outdated Show resolved Hide resolved
src/finch/tensor.py Outdated Show resolved Hide resolved
src/finch/compiled.py Show resolved Hide resolved
src/finch/compiled.py Show resolved Hide resolved
@hameerabbasi hameerabbasi requested a review from mtsokol December 17, 2024 08:54
Copy link
Member

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just typing nitpicks and it's ready.

src/finch/compiled.py Outdated Show resolved Hide resolved
src/finch/compiled.py Outdated Show resolved Hide resolved
src/finch/compiled.py Outdated Show resolved Hide resolved
src/finch/compiled.py Outdated Show resolved Hide resolved
src/finch/compiled.py Outdated Show resolved Hide resolved
@hameerabbasi hameerabbasi merged commit 3c79c44 into finch-tensor:main Dec 17, 2024
5 checks passed
@hameerabbasi hameerabbasi deleted the recursive-compiled branch December 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants