Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update complied function #82

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update complied function #82

merged 1 commit into from
Dec 6, 2024

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Dec 6, 2024

Hi @hameerabbasi,

One missing thing from yesterday's work is def complied update, i.e. removal of get_scheduler(...) call.

@mtsokol mtsokol requested a review from hameerabbasi December 6, 2024 10:42
@mtsokol mtsokol self-assigned this Dec 6, 2024
hameerabbasi
hameerabbasi reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests showing how this would be used?

@mtsokol
Copy link
Member Author

mtsokol commented Dec 6, 2024

Can we add tests showing how this would be used?

Sure! I tweaked test_lazy_mode test so that opt param is actually passed there.

hameerabbasi
hameerabbasi approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once CI is green!

@mtsokol mtsokol merged commit 9f9dcfd into main Dec 6, 2024
5 checks passed
@mtsokol mtsokol deleted the compiled-typo branch December 6, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

Assignees

@mtsokol mtsokol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @hameerabbasi