API: Add verbose mode and lazy indexing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
requested changes
May 7, 2024
|
@hameerabbasi FYI there's one regression that causes one test failure: finch-tensor/Finch.jl#524 |
Let's also add it to |
hameerabbasi
approved these changes
May 7, 2024
|
Thanks for getting to this so quick, @mtsokol! In it goes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hameerabbasi,
This PR:
tns[:, None, :], that adds a new singleton dimension at that position. There's an issue with the rightmostNoneindexing (Lazy indexing - issue with the rightmostnothingdimension Finch.jl#528) but I think we can merge it here and I will update tests once it's solved in Finch.jl.