Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Implement where and nonzero #30

Merged
merged 1 commit into from
Apr 12, 2024
Merged

API: Implement where and nonzero #30

merged 1 commit into from
Apr 12, 2024

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Apr 12, 2024

Hi @willow-ahrens @hameerabbasi,

This PR adds Array API compatible where and nonzero functions.

@mtsokol mtsokol added the enhancement New feature or request label Apr 12, 2024
@mtsokol mtsokol self-assigned this Apr 12, 2024
@mtsokol mtsokol mentioned this pull request Apr 12, 2024
Open
46 tasks
willow-ahrens
willow-ahrens approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me!

@mtsokol mtsokol merged commit ee02fde into main Apr 12, 2024
5 checks passed
@mtsokol mtsokol deleted the where-and-nonzero branch April 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willow-ahrens willow-ahrens willow-ahrens approved these changes

@hameerabbasi hameerabbasi Awaiting requested review from hameerabbasi

Assignees

@mtsokol mtsokol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @willow-ahrens