Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add asarray function #28

Merged
merged 1 commit into from
Mar 29, 2024
Merged

API: Add asarray function #28

merged 1 commit into from
Mar 29, 2024

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Mar 28, 2024

@mtsokol mtsokol added the enhancement New feature or request label Mar 28, 2024
@mtsokol mtsokol self-assigned this Mar 28, 2024
@mtsokol mtsokol requested a review from hameerabbasi March 28, 2024 18:23
hameerabbasi
hameerabbasi reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

src/finch/tensor.py Show resolved Hide resolved
src/finch/tensor.py Outdated Show resolved Hide resolved
@mtsokol mtsokol requested a review from hameerabbasi March 29, 2024 08:36
@mtsokol mtsokol merged commit a78720e into main Mar 29, 2024
5 checks passed
@mtsokol mtsokol deleted the asarray-function branch March 29, 2024 09:38
@mtsokol mtsokol mentioned this pull request Mar 29, 2024
Open
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

Assignees

@mtsokol mtsokol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @hameerabbasi