BLD: Move build to setuptools #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hameerabbasi
requested changes
Jan 24, 2024
finch/_version.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| # file generated by setuptools_scm | |||
There was a problem hiding this comment.
This file shouldn't be in version control and should be added to .gitignore.
|
I think the readme needs updating, I'd also search for other mentions of Poetry. |
Sure! I updated |
hameerabbasi
approved these changes
Jan 24, 2024
This was referenced Jan 24, 2024
Merged
|
I don't have much of value to add to this. Using setuptools seems really important to y'all, so I'm happy to go along with it, especially since it seems like setuptools might support an opportunity to add a build step. LMK if there's anything I need to do (i.e. adding pypi keys to github secrets, etc.) to get the next version published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @willow-ahrens @hameerabbasi,
This PR updates
pyproject.tomlto matchpydata/sparsebuild setup.