Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation for buffered partial messages #829

Merged
merged 1 commit into from
Jan 16, 2025

Implement validation for buffered partial messages

df14ff4
Select commit
Loading
Failed to load commit list.
Merged

Implement validation for buffered partial messages #829

Implement validation for buffered partial messages
df14ff4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

67.32% (-2.11%) compared to d3d8077

View this Pull Request on Codecov

67.32% (-2.11%) compared to d3d8077

Details

Codecov Report

Attention: Patch coverage is 27.44479% with 230 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (d3d8077) to head (df14ff4).

Files with missing lines Patch % Lines
partial_validator.go 22.14% 205 Missing and 13 partials ⚠️
host.go 74.07% 6 Missing and 1 partial ⚠️
partial_msg.go 50.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   69.42%   67.32%   -2.11%     
==========================================
  Files          83       84       +1     
  Lines        8662     8942     +280     
==========================================
+ Hits         6014     6020       +6     
- Misses       2128     2392     +264     
- Partials      520      530      +10     
Files with missing lines Coverage Δ
merkle/merkle.go 92.30% <ø> (ø)
partial_msg.go 59.80% <50.00%> (-22.97%) ⬇️
host.go 64.58% <74.07%> (-0.34%) ⬇️
partial_validator.go 22.14% <22.14%> (ø)

... and 8 files with indirect coverage changes