Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase time upper time buckets in histograms #781

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

masih
Copy link
Member

@masih masih commented Dec 6, 2024

Increase the time upper bound time buckets for histogram metrics that measure:

  • committee fetch time
  • proposal fetch time
  • validation time per message

Fixes #780

Increase the time upper bound time buckets for histogram metrics that
measure:
* committee fetch time
* proposal fetch time
* validation time per message

Fixes #780
@masih masih requested a review from Kubuxu December 6, 2024 15:31
@masih masih enabled auto-merge December 6, 2024 15:37
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (0a6bda4) to head (64a1a70).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   69.36%   69.32%   -0.04%     
==========================================
  Files          76       76              
  Lines        7870     7870              
==========================================
- Hits         5459     5456       -3     
- Misses       1959     1961       +2     
- Partials      452      453       +1     
Files with missing lines Coverage Δ
metrics.go 82.50% <ø> (ø)

... and 3 files with indirect coverage changes

@masih masih added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 6c3d2de Dec 6, 2024
13 checks passed
@masih masih deleted the masih/fix-time-buckets-fetch-time branch December 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get proposal metrics on dashboard look incorrect
2 participants