Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gen.go -> cbor_gen.go #446

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Rename gen.go -> cbor_gen.go #446

merged 1 commit into from
Jul 11, 2024

Conversation

Stebalien
Copy link
Member

fixes #380

@Stebalien Stebalien requested a review from masih July 11, 2024 08:29
@Stebalien
Copy link
Member Author

This likely won't conflict with anything outstanding.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (5aa1e01) to head (8a5719f).

❗ There is a different number of reports uploaded between BASE (5aa1e01) and HEAD (8a5719f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (5aa1e01) HEAD (8a5719f)
4 2
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   75.96%   68.59%   -7.38%     
==========================================
  Files          43       46       +3     
  Lines        3770     4525     +755     
==========================================
+ Hits         2864     3104     +240     
- Misses        620      891     +271     
- Partials      286      530     +244     
Files Coverage Δ
certexchange/cbor_gen.go 38.31% <ø> (ø)
certs/cbor_gen.go 32.77% <ø> (ø)
gpbft/cbor_gen.go 30.55% <ø> (ø)

... and 3 files with indirect coverage changes

@Stebalien Stebalien added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 18fa7de Jul 11, 2024
12 of 13 checks passed
@Stebalien Stebalien deleted the steb/rename-cbg-files branch July 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename gen.go files to cbor_gen.go
2 participants