Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test skip to round #420

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Test skip to round #420

merged 1 commit into from
Jul 7, 2024

Conversation

masih
Copy link
Member

@masih masih commented Jul 7, 2024

Test that instance does not skip to round unless it not in decide phase, it has seen at least weak quorum of prepare and finds a max ticket.

Part of #9

@masih masih requested review from Stebalien and Kubuxu July 7, 2024 12:13
@masih masih force-pushed the masih/test-skip-round branch from 2dc7c64 to 1475639 Compare July 7, 2024 12:13
Test that instance does not skip to round unless it not in decide phase,
it has seen at least weak quorum of prepare and finds a max ticket.

Part of #9
@masih masih force-pushed the masih/test-skip-round branch from 1475639 to 0b6a8e8 Compare July 7, 2024 12:19
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (b5674db) to head (0b6a8e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   74.15%   79.01%   +4.86%     
==========================================
  Files          39       36       -3     
  Lines        3753     3531     -222     
==========================================
+ Hits         2783     2790       +7     
+ Misses        691      465     -226     
+ Partials      279      276       -3     
Files Coverage Δ
emulator/driver_assertions.go 100.00% <100.00%> (+5.61%) ⬆️
gpbft/gpbft.go 86.00% <ø> (+0.27%) ⬆️

... and 6 files with indirect coverage changes

@masih masih added this pull request to the merge queue Jul 7, 2024
Merged via the queue into main with commit 0437e61 Jul 7, 2024
13 checks passed
@masih masih deleted the masih/test-skip-round branch July 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants