improve edge-case coverage

filecoin-project · Aug 29, 2024 · e9683d1 · e9683d1
1 parent c405d69
commit e9683d1
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/test/signing_suite_test.go b/test/signing_suite_test.go
@@ -132,4 +132,17 @@ func (s *SigningTestSuite) TestAggregateAndVerify() {
 
 		require.Error(t, wrongKeyAggregator.VerifyAggregate(mask, msg, aggSig), "wrong pubkey should error")
 	}
+
+	t.Run("mask out of range", func(t *testing.T) {
+		_, err = aggregator.Aggregate([]int{0, 3}, [][]byte{sigs[0]})
+		require.Error(t, err, "mask out of range")
+	})
+
+	t.Run("empty signature is always valid", func(t *testing.T) {
+		sig, err := aggregator.Aggregate([]int{}, [][]byte{})
+		require.NoError(t, err)
+
+		err = aggregator.VerifyAggregate([]int{}, []byte("anything"), sig)
+		require.NoError(t, err)
+	})
 }