Update Wrath IPC to correct Enums #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, passing the enums as is will change the wrong setting as enums are number values behind the scenes, and not strings. So for example, in current version of AD the
Lowest_CurrentDPSRotationMode would be passed as1due to being the second item in the enumeration. However on the Wrath side, the value1corresponds toHighest_Max, so that's what it gets changed to (even if the UI shows otherwise, that's something I'm addressing that side).Going forward it will be safer to push enums with their corresponding values on the Wrath side, which will normally be an index value (unless an item is removed however I am making similar changes to Wrath to put their values in to prevent breaks like this).
If this is merged and released before next Wrath update, the Wrath UI will show incorrectly but will function properly behind the scenes.