Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some duty paths i've been sitting on for a bit #664

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

pot0to
Copy link
Contributor

@pot0to pot0to commented Nov 27, 2024

No description provided.

@erdelf
Copy link
Collaborator

erdelf commented Nov 27, 2024

uh.. several of those dungeons already have paths. What do yours do differently ?

@pot0to
Copy link
Contributor Author

pot0to commented Nov 27, 2024

Oh... I thought since these files weren't in the repo that meant they weren't in AutoDuty. Let me check again which of these files are actually new. What's the proper place to check the list of dungeons with paths, if they're not all checked in here and my %AppData%/XIVLauncher/pluginConfigs/AutoDuty/paths directory might be dirty?

@erdelf
Copy link
Collaborator

erdelf commented Nov 27, 2024

They are in the repo. Halatali and Fractal Continuum for example..

@pot0to
Copy link
Contributor Author

pot0to commented Nov 27, 2024

Alright, I think I've cleaned up the PR, sorry about that. I believe the remaining ones should be new -- at least they all show up as new files in the diff and a manual search of master via browser doesn't bring them up.

@erdelf
Copy link
Collaborator

erdelf commented Nov 27, 2024

looks good, thank you.

@erdelf erdelf merged commit 8d3cb17 into ffxivcode:master Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants