Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): separate prefix from address in agent info #609

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Jan 17, 2025

Proposed Changes

Changing the field address to identifier in AgentInfo breaks the local agent inspector, so since this is not actually needed for the updated almanac attestation, let's simply add prefix as a new field to the AgentInfo model instead.

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

Copy link
Contributor

@dominic22 dominic22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool lgtm!

Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrriehl jrriehl merged commit 379809f into main Jan 17, 2025
9 checks passed
@jrriehl jrriehl deleted the refactor/separate-prefix-from-address-in-agent-info branch January 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants