Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add exp backoff to almanac registration #537

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ejfitzgerald
Copy link
Member

@ejfitzgerald ejfitzgerald commented Oct 1, 2024

Proposed Changes

Add an exponential backoff to the agent registration with the almanac api - in addition extend the amount of retries to 10. The following table outlines the retry scheme implemented

Retry Duration (seconds)
1 0.064
2 0.128
3 0.256
4 0.512
5 1.024
6 2.048
7 4.096
8 8.192
9 16.384
10 32.768
11 65.536
12 131.072
13 131.072
14 131.072
15 131.072

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@ejfitzgerald ejfitzgerald changed the title chore: add exp backoff to almanac registration chore(core): add exp backoff to almanac registration Oct 1, 2024
@ejfitzgerald ejfitzgerald marked this pull request as ready for review October 3, 2024 10:54
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejfitzgerald ejfitzgerald merged commit 6a102e1 into main Oct 3, 2024
10 of 11 checks passed
@ejfitzgerald ejfitzgerald deleted the chore/almanac-api-backoff branch October 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants