Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): digest backwards compatibility #451

Merged
merged 10 commits into from
Jul 10, 2024
Merged

fix(core): digest backwards compatibility #451

merged 10 commits into from
Jul 10, 2024

Conversation

Archento
Copy link
Member

@Archento Archento commented Jul 9, 2024

Reverting back to the old way of schema generation to be compatible with current agents.

We will introduce a transitory period of supporting both schemes in the near future to provide a chance for users to properly migrate,

@Archento Archento requested review from jrriehl and lrahmani as code owners July 9, 2024 09:55
jrriehl
jrriehl previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jrriehl
jrriehl reviewed Jul 9, 2024
View reviewed changes
python/pyproject.toml Outdated Show resolved Hide resolved
lrahmani
lrahmani reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lrahmani lrahmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should restore backward compatibility with uagents 0.12.2 for models, envelopes and protocols

python/src/uagents/__init__.py Show resolved Hide resolved
python/src/uagents/models.py Show resolved Hide resolved
python/src/uagents/protocol.py Show resolved Hide resolved
@lrahmani lrahmani changed the title fix(core): digest backwards compatibility fix(core): digest backwards compatibility with pydantic v1 Jul 10, 2024
@lrahmani lrahmani changed the title fix(core): digest backwards compatibility with pydantic v1 fix(core): digest backwards compatibility Jul 10, 2024
@Archento Archento requested a review from lrahmani July 10, 2024 08:23
lrahmani
lrahmani previously approved these changes Jul 10, 2024
View reviewed changes
@Archento Archento merged commit b85efdb into main Jul 10, 2024
9 checks passed
@Archento Archento deleted the fix/digest-backcompat branch July 10, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl left review comments

@qati qati qati left review comments

@lrahmani lrahmani lrahmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Archento @lrahmani @qati @jrriehl